-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajout de metrique dans AT et approche multiresolution. Noemie Tasca, … #344
base: master
Are you sure you want to change the base?
Conversation
…stagiaire de Jacques-Olivier Lachaud
Hi Noemie ! For the last three points, they are easily handled:
|
Hi @NoemieTasca @JacquesOlivierLachaud do you think that it is ready for review ? (or better waiting after 1.0 ?) |
ping @JacquesOlivierLachaud can I review it ? I suppose yes since the check are greens ;) |
Honnestly I had completely forgotten this PR and even the commits I made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JacquesOlivierLachaud I get the same error of #354 since I have set the ITK option in DGtal.
/Users/kerautre/EnCours/DGtal/src/DGtal/math/linalg/CVectorSpace.h:103:11: error: no member named 'clear' in 'itkeigen::Matrix<double, -1, -1, 0, -1, -1>' z.clear();
When I unset it worlds fine, but if you see the issue mentioned by @phcerdan perhaps it is a good occasion to check it else no problem to merge and link it it in issue for later. Just fix the changelog with @NoemieTasca name ;)
Co-authored-by: Bertrand Kerautret <[email protected]>
Co-authored-by: Bertrand Kerautret <[email protected]>
I have to check this PR more. Noemie had a lot of weird problem when doing multi scale approaches. I do not know yet if it is a conceptual problem or simply a bug. |
@NoemieTasca since news changes with CLI prog options were made, to help I PR on your branch the merge: NoemieTasca#1 |
In the PR I also apply new change with CL11 in link to previous PR. |
[stagiaire de Jacques-Olivier Lachaud]
PR not ready yet. Working on it.
Thanks a lot for contributing to DGtalTools, before submitting your PR, please fill up the description and make sure that all checkboxes are checked.
PR Description
Metric : Taking into account the metric in the discrete formulation of Ambrosio-Tortorelli.
Multiresolution : Adding a multi-scale resolution in image restoration using Ambrosio-Tortorelli.
Checklist
cmake
mode (otherwise, Travis C.I. will fail).