-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] Standard naming for TokenManager service classes #7895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Nov 19, 2024
fstagni
reviewed
Nov 19, 2024
@@ -1,6 +1,8 @@ | |||
"""TokenManager service is responsible for token management, namely storing, updating, | |||
"""TokenManager service is a HTTPs-exposed service responsible for token management, namely storing, updating, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"""TokenManager service is a HTTPs-exposed service responsible for token management, namely storing, updating, | |
"""TornadoTokenManager service is a HTTPs-exposed service responsible for token management, namely storing, updating, |
src/DIRAC/FrameworkSystem/Service/TornadoTokenManagerHandler.py
Outdated
Show resolved
Hide resolved
fstagni
approved these changes
Nov 19, 2024
DIRACGridBot
added
sweep:done
All sweeping actions have been done for this PR
sweep:failed
Sweeping failed and needs manual intervention
labels
Nov 19, 2024
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/11916702132 Failed:
|
fstagni
added a commit
to fstagni/DIRAC
that referenced
this pull request
Nov 20, 2024
[8.0] Standard naming for TokenManager service classes (cherry picked from commit 6504d15)
fstagni
pushed a commit
to fstagni/DIRAC
that referenced
this pull request
Nov 20, 2024
fstagni
added a commit
to fstagni/DIRAC
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alsoTargeting:integration
Cherry pick this PR to integration after merge
sweep:done
All sweeping actions have been done for this PR
sweep:failed
Sweeping failed and needs manual intervention
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #7888 to make names for the service handlers following the standard convention. The PR propagated to integration replaces #7893. This also means that upon the update the DIRAC installations using already the Tornado TokenManager service will have to update the TokenManager service configuration by adding the HandlerPath option:
This will be reflected in the release notes and instructions
BEGINRELEASENOTES
*Framework
CHANGE: Rename TokenManager service classes to follow standard convention for tornado and diset handlers
ENDRELEASENOTES