Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dBiz. #802

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update dBiz. #802

wants to merge 2 commits into from

Conversation

rl2939
Copy link
Contributor

@rl2939 rl2939 commented Feb 19, 2025

No description provided.

@falkTX
Copy link
Contributor

falkTX commented Feb 19, 2025

huh their update adds temporary build binary objects to the repo, we dont want those.

we should either tell them (as bug report) or submit a fix, including updating their .gitignore so it doesnt happen again

@dromer
Copy link
Collaborator

dromer commented Feb 19, 2025

@falkTX already did so: dBiz/dBiz#67

This is not something we can fix really, as the git history is already tainted with these files.
Ok updating the .gitignore we can help with, but ideally these files are purged from the git history so that the repo size is reduced instead of increased further.

@falkTX
Copy link
Contributor

falkTX commented Feb 19, 2025

nice, but a few MB for Cardinal repo is not going to make a big difference, we have juce as submodule which balloons the entire thing.
I am more concerned for the release source tarball, that should be clean of such files.

@dromer
Copy link
Collaborator

dromer commented Feb 19, 2025

Well it's another 50-100M for syncing the repo that is completely unnecessary.
(and as someone that regularly devs while on the train or bus it matters a lot)

And it's bad practice in general. Better if they clean it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants