-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add progress timeline, update transaction screen ui and functionality #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for test-mint-dlc-link ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-mint-dlc-link ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Polybius93
force-pushed
the
feat/transaction-timeline
branch
from
September 25, 2024 15:16
5c3cfdf
to
d1e566e
Compare
sosaucily
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve, just with some small refactor recommendations. Nice!
src/app/components/modals/successful-flow-modal/successful-flow-modal.tsx
Show resolved
Hide resolved
...gress-stack/components/transaction-screen.transaction-form.progress-stack.mint-variant-c.tsx
Outdated
Show resolved
Hide resolved
...-screen.transaction-form/components/transaction-screen.transaction-form.protocol-fee-box.tsx
Show resolved
Hide resolved
sosaucily
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a progress timeline to the transaction screens and updates the logic for rendering components based on specific conditions. It also introduces new navigational buttons and adjusts the observer to dispatch actions conditionally, depending on the event type.