Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xrpl #202

Merged
merged 38 commits into from
Nov 21, 2024
Merged

feat: add xrpl #202

merged 38 commits into from
Nov 21, 2024

Conversation

Polybius93
Copy link
Collaborator

This PR adds XRPL network as option for the minting/redeeming flow.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for test-mint-dlc-link ready!

Name Link
🔨 Latest commit 62bff84
🔍 Latest deploy log https://app.netlify.com/sites/test-mint-dlc-link/deploys/673e0210ba7ad200087e7b83
😎 Deploy Preview https://deploy-preview-202--test-mint-dlc-link.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for dev-mint-dlc-link ready!

Name Link
🔨 Latest commit 62bff84
🔍 Latest deploy log https://app.netlify.com/sites/dev-mint-dlc-link/deploys/673e02100d0d06000821a7a3
😎 Deploy Preview https://deploy-preview-202--dev-mint-dlc-link.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sosaucily sosaucily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite good! mostly these are just improvement ideas, except perhaps for the configuration file recommendation.

Also, there are quite a lot of lint errors. Can you add a lint-exception for those? or delete them

config.testnet.json Show resolved Hide resolved
src/app/hooks/use-confirmation-checker.ts Outdated Show resolved Hide resolved
src/app/hooks/use-connected.ts Outdated Show resolved Hide resolved
src/app/hooks/use-psbt.ts Outdated Show resolved Hide resolved
src/app/hooks/use-xrpl-ledger.ts Show resolved Hide resolved
src/app/providers/network-configuration.provider.tsx Outdated Show resolved Hide resolved
config.testnet.json Outdated Show resolved Hide resolved
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for mint-dlc-link ready!

Name Link
🔨 Latest commit 62bff84
🔍 Latest deploy log https://app.netlify.com/sites/mint-dlc-link/deploys/673e021051ddba00086934c0
😎 Deploy Preview https://deploy-preview-202--mint-dlc-link.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Polybius93 Polybius93 merged commit fd97e61 into dev Nov 21, 2024
19 checks passed
@Polybius93 Polybius93 deleted the feat/multi-chain branch November 21, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants