Feat/1cy card UI #208
Merged
Feat/1cy card UI #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polybius93
requested changes
Nov 6, 2024
...pe-stack.vault-type-box/one-click-yield-container.select-vault-type-stack.vault-type-box.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
46
to
88
| <HStack w={'100%'} justifyContent={'space-between'}> | ||
| <HStack> | ||
| <Image src={vaultTypeLogoUrl} alt={'Enzyme logo'} /> | ||
| <InfoOutlineIcon color={'purple.01'} /> | ||
| </HStack> | ||
| <Button | ||
| variant={'depositBTC'} | ||
| // _hover={{ bg: 'orange.01', color: 'white.01' }} | ||
| onClick={() => handleSelectVaultTypeClick(vaultType)} | ||
| > | ||
| <HStack> | ||
| <Image src={'/images/deposit-img.png'} alt={'Deposit image'} /> | ||
| <Text fontSize={'lg'} fontWeight={'800'} color={'white.01'}> | ||
| Deposit BTC | ||
| </Text> | ||
| </HStack> | ||
| </Button> | ||
| </HStack> | ||
| <HStack alignItems={'flex-start'} w={'100%'}> | ||
| <VStack alignItems={'flex-start'} w={'30%'}> | ||
| <Text fontSize={'md'} fontWeight={'800'} color={'white.02'}> | ||
| Current APY | ||
| </Text> | ||
| <Text fontSize={'lg'} fontWeight={'800'} color={'white.01'}> | ||
| +12.5% | ||
| </Text> | ||
| </VStack> | ||
| <VStack alignItems={'flex-start'} w={'70%'}> | ||
| <Text fontSize={'md'} fontWeight={'800'} color={'white.02'}> | ||
| Points | ||
| </Text> | ||
| <HStack> | ||
| {mockPointChips.map(pointChip => ( | ||
| <VaultTypeBoxPointChip | ||
| key={pointChip.multiplier} | ||
| bgColor={pointChip.bgColor} | ||
| imgPath={pointChip.imgPath} | ||
| multiplier={pointChip.multiplier} | ||
| /> | ||
| ))} | ||
| </HStack> | ||
| </VStack> | ||
| </HStack> |
There was a problem hiding this comment.
can you break it down into smaller components or reusable components?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
one-click-yield-containercomponent, primarily focusing on adding new features and improving the layout and styling. The most important changes include the addition of new vault types with logos, the creation of a newVaultTypeBoxPointChipcomponent, and updates to theVaultTypeBoxlayout.New Features:
mockVaultTypesarray inone-click-yield-container.select-vault-type-stack.tsx.VaultTypeBoxPointChipcomponent to display point multipliers with an image and background color.Layout and Styling Improvements:
VaultTypeBoxLayoutto useVStackinstead ofHStack, adjusted spacing, and added background color.VaultTypeBoxto include vault type logos, an info icon, a new button style, and additional sections for displaying APY and points.depositBTCstyle variant to the button theme configuration.These changes collectively enhance the user interface and user experience of the
one-click-yield-containerby providing more visual information and improving the layout consistency.