-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timelocked contract upgrades #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scolear
force-pushed
the
feat/timelocked-upgrades
branch
from
October 8, 2024 18:05
6ca534c
to
5a0ee77
Compare
scolear
force-pushed
the
feat/timelocked-upgrades
branch
from
October 9, 2024 12:49
ac2c8f9
to
20e6515
Compare
Rayerleier
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thoroughly reviewed this code, and I think it’s very well-structured. It also takes into account the possibility of reentrancy attacks, so I believe there are no issues with it.
scolear
commented
Oct 22, 2024
scolear
commented
Oct 22, 2024
scolear
commented
Oct 22, 2024
sosaucily
reviewed
Oct 25, 2024
sosaucily
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a TimelockController contract in front of the ProxyAdmin to add a mandatory delay for smart contract upgrades.
Eventually, this could also be used to add a delay for regular DLCAdmin functions on our contracts.