Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelocked contract upgrades #120

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Timelocked contract upgrades #120

merged 7 commits into from
Oct 29, 2024

Conversation

scolear
Copy link
Contributor

@scolear scolear commented Oct 8, 2024

Adding a TimelockController contract in front of the ProxyAdmin to add a mandatory delay for smart contract upgrades.

Eventually, this could also be used to add a delay for regular DLCAdmin functions on our contracts.

Screenshot 2024-10-09 at 16 45 36

@scolear scolear force-pushed the feat/timelocked-upgrades branch from 6ca534c to 5a0ee77 Compare October 8, 2024 18:05
@scolear scolear marked this pull request as ready for review October 9, 2024 12:48
@scolear scolear force-pushed the feat/timelocked-upgrades branch from ac2c8f9 to 20e6515 Compare October 9, 2024 12:49
Copy link

@Rayerleier Rayerleier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thoroughly reviewed this code, and I think it’s very well-structured. It also takes into account the possibility of reentrancy attacks, so I believe there are no issues with it.

scripts/50_contract-admin.js Outdated Show resolved Hide resolved
scripts/50_contract-admin.js Outdated Show resolved Hide resolved
scripts/50_contract-admin.js Outdated Show resolved Hide resolved
scripts/50_contract-admin.js Show resolved Hide resolved
@scolear scolear merged commit b0c0d98 into dev Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants