Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated scripts including deployment and common single-purposed scripts. Rewards component and Deployment Logs #10

Merged
merged 26 commits into from
Jan 13, 2025
Merged

Updated scripts including deployment and common single-purposed scripts. Rewards component and Deployment Logs #10

merged 26 commits into from
Jan 13, 2025

Conversation

Rayerleier
Copy link
Contributor

@Rayerleier Rayerleier commented Dec 18, 2024 •
edited
Loading

Notes:

  • Added a flowchart illustrating the dependencies for each step.
  • Modified iBTC_NetworkMiddleware to include functionality related to Rewards.
  • Made changes in the Deploy_All.s.sol script:
    • Removed unnecessary code.
    • Replaced NETWORK with NetworkMock for simulation purposes.
    • Deployed the iBTC_NetworkMiddleware with the Reward feature, where the RewardToken is simulated by RewardTokenMock.
  • Added utility scripts in the script/common directory for common operations.
  • Updated two test files to adapt to the new iBTC_NetworkMiddleware.
  • Introduced NetworkMock to simulate the Network.

@Rayerleier Rayerleier changed the title Updated scripts including deployment and common single-purposed scripts Updated scripts including deployment and common single-purposed scripts. Rewards component and Deployment Logs Jan 7, 2025
scolear
scolear previously approved these changes Jan 13, 2025
View reviewed changes
@Rayerleier Rayerleier dismissed scolear’s stale review January 13, 2025 14:43

The merge-base changed after approval.

scolear
scolear previously approved these changes Jan 13, 2025
View reviewed changes
@Rayerleier Rayerleier dismissed scolear’s stale review January 13, 2025 14:58

The merge-base changed after approval.

Polybius93
Polybius93 previously approved these changes Jan 13, 2025
View reviewed changes
Copy link

@Polybius93 Polybius93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rayerleier Rayerleier dismissed Polybius93’s stale review January 13, 2025 15:05

The merge-base changed after approval.

@scolear scolear merged commit 3dc4d4c into main Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scolear scolear scolear approved these changes

@Polybius93 Polybius93 Polybius93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rayerleier @scolear @Polybius93