Pack/Unpack data for user-data #1224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davknapp
added
New feature
and pack and unpack without prefix for the size
Co-authored-by: David Knapp <[email protected]>
Co-authored-by: David Knapp <[email protected]>
add placeholder for internal data handling
sandro-elsweijer
requested changes
Jan 3, 2025
|
A C-interface will be implemented in #1357 |
sandro-elsweijer
approved these changes
Jan 31, 2025
Comment on lines
+43
to
+44
| * \class t8_single_data_handler | ||
| * \brief A template specialisation for handling single enlarged ints (int plus an additional int, this |
There was a problem hiding this comment.
Suggested change
| * \class t8_single_data_handler | |
| * \brief A template specialisation for handling single enlarged ints (int plus an additional int, this | |
| * A template specialisation for handling single enlarged ints (int plus an additional int, this |
| */ | ||
|
|
||
| /** | ||
| * \brief pseudo_types for testing |
There was a problem hiding this comment.
Suggested change
| * \brief pseudo_types for testing | |
| * pseudo_types for testing |
Comment on lines
+45
to
+46
| * \class t8_single_data_handler | ||
| * \brief A template class for handling single data items. |
There was a problem hiding this comment.
Suggested change
| * \class t8_single_data_handler | |
| * \brief A template class for handling single data items. | |
| * Template class for handling single data items. |
|
|
||
| private: | ||
| /** | ||
| * \brief A shared pointer to a vector of data. |
There was a problem hiding this comment.
Suggested change
| * \brief A shared pointer to a vector of data. | |
| * A shared pointer to a vector of data. |
| */ | ||
| std::shared_ptr<std::vector<TType>> m_data; | ||
| /** | ||
| * \brief A single data handler for the data type T. |
There was a problem hiding this comment.
Suggested change
| * \brief A single data handler for the data type T. | |
| * A single data handler for the data type T. |
| } | ||
|
|
||
| /** | ||
| * \brief Get the data. |
There was a problem hiding this comment.
Suggested change
| * \brief Get the data. | |
| * Get the data. |
Comment on lines
+133
to
+134
| * \class t8_data_handler | ||
| * \brief A template class for handling data in a distributed environment. |
There was a problem hiding this comment.
Suggested change
| * \class t8_data_handler | |
| * \brief A template class for handling data in a distributed environment. | |
| * A template class for handling data in a distributed environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interface for arbitrary data.
For new user-data it suffies to implement how a single element should be packed/unpacked.
The routines for vectors of user-data make use of this routine and pack/unpack the data accordingly.
Furthermore it provides a wrapper around the send/recv routine from MPI for to avoid code duplication and easy usage. This part of the interface should be extended in the future to other MPI send/recv routines.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.Licence
doc/(or already has one)