feat: report failed reads and do not block on empty queuing port #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenautumns
previously approved these changes
Nov 8, 2024
a653rs-router/src/ports.rs
Outdated
| @@ -36,11 +36,14 @@ impl<S: ApexSamplingPortP4> RouterOutput for SamplingPortSource<S> { | |||
|
|
|||
| impl<Q: ApexQueuingPortP4> RouterInput for QueuingPortReceiver<Q> { | |||
| fn receive<'a>(&self, buf: &'a mut [u8]) -> Result<&'a [u8], PortError> { | |||
| let timeout = SystemTime::Normal(Duration::from_micros(10)); | |||
| let timeout = SystemTime::Normal(Duration::from_secs(0)); | |||
There was a problem hiding this comment.
There is a constant for zero.
https://doc.rust-lang.org/std/time/struct.Duration.html#associatedconstant.ZERO
dadada
force-pushed
the
dev/report-failed-reads
branch
from
b8858b4 to
6033a55
Compare
sevenautumns
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.