Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Testsuite Runner #112

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

nerodesu017
Copy link
Collaborator

@nerodesu017 nerodesu017 commented Dec 16, 2024

Pull Request Overview

This is an on-going PR focused on making the spec test runner work again + add more to it.
Additions:

  • filtering (either Include or Exclude) based on files and folders (so we can discard the proposals folder, for example, or files related to SIMD, which we do not implement (yet), and that give us a rough time)
  • assert_trap being implemented
  • a few debug (with debug_assertions) related code for stringifying errors and other features for QoL when debugging
  • changes to how we cast certain values (especially F64 and F32) so that we get the desired results (mostly bit reinterpretation, not normal casting, this is in part because the crate that we use for parsing WAST files parses these values into u32 and u64, respectively, and we have to reinterpret the bits - see Future bug: Potential float alteration on some architectures #28 for more info)
  • a fix for a Span that we return when reading a constant expression (for example, for a global) because we were returning 1 more byte, this wouldn't be a problem, as we stop on the END instruction, but it is a problem when the END is EOF and we return +1 byte and we throw an error when doing a later check - see src/validation/read_constant_expression.rs

Testing Strategy

This pull request was tested by... N/A

TODO or Help Wanted

This pull request still needs... N/A

Formatting

  • Ran cargo fmt
  • Ran cargo check
  • Ran cargo build
  • Ran cargo doc
  • Ran nix fmt

Github Issue

This pull request closes <GITHUB_ISSUE>

@nerodesu017 nerodesu017 force-pushed the nero/dev/testsuite-runner branch from 875b3b7 to b32f727 Compare December 17, 2024 12:34
@nerodesu017 nerodesu017 force-pushed the nero/dev/testsuite-runner branch from 4865d09 to f1f4d8c Compare December 17, 2024 12:59
@nerodesu017 nerodesu017 force-pushed the nero/dev/testsuite-runner branch from 14f2dd5 to 5d776f7 Compare December 17, 2024 13:24
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 97.52066% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/execution/mod.rs 93.47% 1 Missing and 2 partials ⚠️
src/execution/value_stack.rs 0.00% 2 Missing ⚠️
src/core/error.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/core/reader/types/opcode.rs 100.00% <100.00%> (ø)
src/core/utils.rs 100.00% <100.00%> (ø)
src/execution/function_ref.rs 53.33% <ø> (ø)
src/execution/interpreter_loop.rs 98.09% <100.00%> (+6.68%) ⬆️
src/validation/code.rs 64.68% <100.00%> (+5.14%) ⬆️
src/validation/read_constant_expression.rs 74.35% <100.00%> (+12.82%) ⬆️
src/core/error.rs 19.14% <0.00%> (+16.29%) ⬆️
src/execution/value_stack.rs 82.17% <0.00%> (-0.65%) ⬇️
src/execution/mod.rs 91.46% <93.47%> (+0.98%) ⬆️

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant