add hooks #12
Merged
add hooks #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wucke13
force-pushed
the
dev/add-hooks
branch
2 times, most recently
from
c743c88 to
01ea353
Compare
|
The API proposed looks good. It might be just accidental, but you also pushed the requirements onto this branch. |
This is quite useful for example when doing statement coverage. One could store a MPSC tx end inside a BranchHookSet in order to send the current program counter on every branching instruction. Stateless are still possible and should be zero cost, they can be implemented by just using an empty struct on which the HookSet trait is implemented.
valexandru
approved these changes
Jul 10, 2024
nerodesu017
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds a mechanism for downstream developer specifiable hooks, that hopefully is zero cost when unused.
Testing Strategy
This pull request was tested by a custom benchmark to assess performance impact.
TODO or Help Wanted
This pull request still needs more benchmarks, and feedback on the proposed API.
Formatting
cargo fmtcargo checkcargo buildGithub Issue
This pull request closes #11
Author
Signed-off-by: wucke13 [email protected]