Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linker Feature - The Lost Commit #123

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Linker Feature - The Lost Commit #123

merged 1 commit into from
Jan 25, 2025

Conversation

george-cosma
Copy link
Collaborator

There was one more commit that resolved some comments for #87 . Unfortunately, Github auto-merged faster than it disabled the merging.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/execution/mod.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/execution/lut.rs 96.00% <ø> (+2.00%) ⬆️
src/validation/mod.rs 81.21% <100.00%> (-0.45%) ⬇️
src/execution/mod.rs 91.94% <0.00%> (ø)

Copy link
Collaborator

@nerodesu017 nerodesu017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wucke13 wucke13 added this pull request to the merge queue Jan 25, 2025
Merged via the queue into main with commit 05664f7 Jan 25, 2025
12 checks passed
@wucke13 wucke13 deleted the dev/linker-fix branch January 25, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants