Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine requirements w/r/t dependencies #51

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

wucke13
Copy link
Collaborator

@wucke13 wucke13 commented Jul 24, 2024

Pull Request Overview

A recent discussion in issue #50 sparked a need for clarification w/r/t the introduction of dependencies. This commit adds requirements to answer the questions w/r/t dependencies.

Testing Strategy

This pull request was not tested.

TODO or Help Wanted

This pull request still needs someone to review the formulations

Formatting

  • Ran cargo fmt
  • Ran cargo check
  • Ran cargo build
  • Ran cargo doc
  • Ran nix fmt
  • Ran treefmt

Github Issue

This pull request clarifies #50

@wucke13 wucke13 added the documentation Improvements or additions to documentation label Jul 24, 2024
Copy link

github-actions bot commented Jul 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-31 14:37 UTC

@wucke13
Copy link
Collaborator Author

wucke13 commented Jul 24, 2024

How about:

  • add version numbers to dependencies
  • s/num-traits/libm/
  • pinpoint to exact versions TOML.

Any comments, @valexandru

A recent discussion in issue #50 sparked a need for clarification w/r/t
the introduction of dependencies. This commit adds requirements to
answer the questions w/r/t dependencies.

Signed-off-by: wucke13 <[email protected]>
@wucke13 wucke13 force-pushed the dev/wucke13-refine-req branch from d7735e2 to 41b0848 Compare July 24, 2024 16:00
@wucke13 wucke13 requested a review from valexandru July 25, 2024 12:59
@wucke13 wucke13 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit fba9a3f Jul 31, 2024
9 checks passed
@wucke13 wucke13 deleted the dev/wucke13-refine-req branch August 15, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants