Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): transactions for the wasm reader #69

Merged
merged 4 commits into from
Aug 19, 2024
Merged

feat(core): transactions for the wasm reader #69

merged 4 commits into from
Aug 19, 2024

Conversation

florianhartung
Copy link
Collaborator

Pull Request Overview

This pull request adds a transaction wrapper function for the WASM reader.

Testing Strategy

This pull request was not tested.

Formatting

  • Ran cargo fmt
  • Ran cargo check
  • Ran cargo build
  • Ran cargo doc
  • Ran nix fmt
  • Ran treefmt

Github Issue

This pull request does not close any issues.

@florianhartung
Copy link
Collaborator Author

The map_err call can be replaced with the newer inspect_err, which would be a bit cleaner IMO.
However using Result::inspect_err would change our MSRV to 1.76.0, so I was unsure if I could use it.

@florianhartung florianhartung requested a review from wucke13 August 15, 2024 16:29
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/core/reader/mod.rs 98.51% <100.00%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

@florianhartung florianhartung force-pushed the dev/wasm-reader-transaction branch from a6e1f13 to 64eeabb Compare August 16, 2024 10:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-19 09:46 UTC

@florianhartung
chore: cleanup tree fmt
207027e 
Signed-off-by: Florian Hartung <[email protected]>
@florianhartung
chore!: raise MSRV to 1.76.0
0ba235b 
Signed-off-by: Florian Hartung <[email protected]>
@florianhartung florianhartung force-pushed the dev/wasm-reader-transaction branch 2 times, most recently from 6e9d8bd to f4759d7 Compare August 16, 2024 10:49
wucke13
wucke13 previously approved these changes Aug 16, 2024
View reviewed changes
valexandru
valexandru previously approved these changes Aug 16, 2024
View reviewed changes
src/core/reader/mod.rs Show resolved Hide resolved
@wucke13 wucke13 dismissed stale reviews from valexandru and themself via 13c2e72 August 19, 2024 08:01
@wucke13 wucke13 force-pushed the dev/wasm-reader-transaction branch from f4759d7 to 13c2e72 Compare August 19, 2024 08:01
@wucke13 wucke13 force-pushed the dev/wasm-reader-transaction branch from 12d0c5a to 6c2d33a Compare August 19, 2024 08:16
george-cosma
george-cosma approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@george-cosma george-cosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wucke13 wucke13 added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 4f9a9e5 Aug 19, 2024
13 checks passed
@wucke13 wucke13 deleted the dev/wasm-reader-transaction branch August 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-cosma george-cosma george-cosma approved these changes

@wucke13 wucke13 wucke13 approved these changes

@valexandru valexandru valexandru left review comments

Assignees
No one assigned
Labels
core priority-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florianhartung @valexandru @wucke13 @george-cosma