Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make pages_deploy_main.yaml to pull submodules #90

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

george-cosma
Copy link
Collaborator

Github pages dceployment fails now. Woops.
Bug introduced in #32

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@george-cosma george-cosma added bug Something isn't working workflows Adding or modifying GitHub workflows labels Sep 24, 2024
Copy link
Collaborator

@nerodesu017 nerodesu017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't actually test without pushing so... Let's try?

@george-cosma
Copy link
Collaborator Author

@george-cosma george-cosma added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 7555d9d Sep 25, 2024
14 checks passed
@george-cosma george-cosma deleted the fix/submodules branch September 25, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-high workflows Adding or modifying GitHub workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants