Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some changes for compatibility with OCCT 7.6.2 #983

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

joergbrech
Copy link
Contributor

@joergbrech joergbrech commented Dec 14, 2023

This PR is not onto the main branch, but adds changes to the PR #971. These changes were necessary for me to build TiGL locally using OCCT 7.6.2, see #971 (comment)

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #983 (d73616e) into occt_761 (03bc3bf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           occt_761     #983   +/-   ##
=========================================
  Coverage     68.90%   68.90%           
=========================================
  Files           298      298           
  Lines         26476    26476           
=========================================
  Hits          18244    18244           
  Misses         8232     8232           
Files Coverage Δ
src/configuration/CCPACSConfiguration.cpp 57.14% <ø> (ø)

@rainman110
Copy link
Collaborator

Looks good to me 👍

@rainman110
Copy link
Collaborator

I wonder, why It compiled on my installation. I guess, I installed Octc 7.6.1 into an old installation directory, hence the missing header files were still there.

@joergbrech joergbrech merged commit cd087d8 into occt_761 Dec 14, 2023
16 of 17 checks passed
@joergbrech joergbrech deleted the occt_761-joergbrech branch December 14, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants