Merge pull request #136 from DMDcoin/alpha4 · DMDcoin/diamond-node@edfc826

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run cargo check evmbin: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L19

unused import: `Public`

Run cargo check evmbin: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L283

unused variable: `e`

Run cargo check evmbin: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L158

variable does not need to be mutable

Run cargo check evmbin: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L19

fields `staking_address`, `socket_addr`, and `public_key` are never read

Run cargo check evmbin: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L302

method `disconnect_pending_validators` is never used

Run cargo check evmbin: crates/ethcore/src/client/test_client.rs#L425

missing documentation for a method

Run cargo check evmbin

`ethcore` (lib) generated 6 warnings (run `cargo fix --lib -p ethcore` to apply 3 suggestions)

Run cargo check evmbin: bin/evmbin/src/main.rs#L339

field `cmd_stats` is never read

Run cargo check evmbin

`evmbin` (bin "openethereum-evm") generated 1 warning

Run cargo check evmbin

the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24

Run cargo check 1/3: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L19

unused import: `Public`

Run cargo check 1/3: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L283

unused variable: `e`

Run cargo check 1/3: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L158

variable does not need to be mutable

Run cargo check 1/3: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L19

fields `staking_address`, `socket_addr`, and `public_key` are never read

Run cargo check 1/3: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L302

method `disconnect_pending_validators` is never used

Run cargo check 1/3

`ethcore` (lib) generated 5 warnings (run `cargo fix --lib -p ethcore` to apply 3 suggestions)

Run cargo check 1/3: bin/oe/account_utils.rs#L19

unused import: `crypto::publickey`

Run cargo check 1/3: bin/oe/account_utils.rs#L21

unused import: `H160`

Run cargo check 1/3

`diamond-node` (lib) generated 2 warnings (run `cargo fix --lib -p diamond-node` to apply 2 suggestions)

Run cargo check 1/3

the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24

Run cargo check benches: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L19

unused import: `Public`

Run cargo check benches: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L283

unused variable: `e`

Run cargo check benches: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L158

variable does not need to be mutable

Run cargo check benches: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L19

fields `staking_address`, `socket_addr`, and `public_key` are never read

Run cargo check benches: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L302

method `disconnect_pending_validators` is never used

Run cargo check benches: crates/ethcore/src/client/test_client.rs#L425

missing documentation for a method

Run cargo check benches

`ethcore` (lib) generated 6 warnings (run `cargo fix --lib -p ethcore` to apply 3 suggestions)

Run cargo check benches: crates/db/memory-db/benches/bench.rs#L47

unnecessary trailing semicolon

Run cargo check benches

`memory-db` (bench "bench") generated 1 warning

Run cargo check benches: bin/evmbin/src/main.rs#L339

field `cmd_stats` is never read

Install 1.59 toolchain

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Install 1.59 toolchain

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Install 1.59 toolchain

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Install 1.59 toolchain

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge pull request #136 from DMDcoin/alpha4 #131

Check

Merge pull request #136 from DMDcoin/alpha4 #131

Jobs

Run details

Annotations

Check

Re-running jobs...