-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Refresh" to "Edit" TOTP #2269
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2269 +/- ##
=======================================
Coverage 47.05% 47.05%
=======================================
Files 249 249
Lines 13209 13209
=======================================
Hits 6215 6215
Misses 6994 6994
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@Xyene why did you merge this? Editing |
Also isn't https://github.com/DMOJ/online-judge/pull/2269/files#diff-643b1e64ddd6a6bf50ff74bb6a83c23d40faca036dd3f208124aa4ec85c2d888R5511 just wrong anyway... |
@@ -5508,7 +5508,7 @@ msgid "Total:" | |||
msgstr "Total:" | |||
|
|||
#: templates/submission/list.html:350 | |||
msgid "You were disconnected. Refresh to show latest updates." | |||
msgid "You were disconnected. Edit to show latest updates." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is wrong.
why are you editing the po files manually?
we should merge #2142 soon to cover up these po changes |
No, that'll just create a conflict or not do anything. This change is bogus and has been reverted. |
Closes #1839, just cleaning some of my issues opened long ago