Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code for chart colors #2279

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Clean up code for chart colors #2279

merged 1 commit into from
Aug 25, 2023

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Aug 25, 2023

both codes produce the same values for chart_colors and highlight_colors. i.e.

['#3366CC', '#DC3912', '#FF9900', '#109618', '#990099', '#3B3EAC', '#0099C6', '#DD4477', '#66AA00', '#B82E2E', '#316395', '#994499', '#22AA99', '#AAAA11', '#6633CC', '#E67300', '#8B0707', '#329262', '#5574A6', '#3B3EAC']
['#3D7AF4', '#FF4415', '#FFB700', '#13B41C', '#B700B7', '#464ACE', '#00B7ED', '#FF518E', '#7ACC00', '#DC3737', '#3A76B2', '#B751B7', '#28CCB7', '#CCCC14', '#7A3DF4', '#FF8A00', '#A60808', '#3CAF75', '#668BC7', '#464ACE']

quantum5
quantum5 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More functional, nice.

@quantum5 quantum5 added this pull request to the merge queue Aug 25, 2023
Merged via the queue into DMOJ:master with commit 7294d22 Aug 25, 2023
@int-y1 int-y1 deleted the color-type branch August 25, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantum5 quantum5 quantum5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@int-y1 @quantum5