#3144 Upgrade to Bootstrap 5 #3357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjacob24
requested review from
briri,
lagoan,
martaribeiro,
benjaminfaure,
aaronskiba and
dstuckey-uoe
Generated by 🚫 Danger |
|
Please don't review PR yet. In the process of creating a wiki for this upgrade @gjacob24 and I decided to go through the following migration documents:
@gjacob24 had suggested we shouldn't rush PR creation before, advice I ignored wanting push code out because the issue was dragging on. Now I realise this was a bad idea, as to do a proper job we need to check code with above-mentioned documentation and remove obsolete classes, etc. |
johnpinto1
force-pushed
the
issue_3144_upgrade_to_bootstrap_5
branch
3 times, most recently
from
9eb9cd7 to
1bf4922
Compare
johnpinto1
force-pushed
the
issue_3144_upgrade_to_bootstrap_5
branch
3 times, most recently
from
26d9503 to
110ee1f
Compare
johnpinto1
force-pushed
the
issue_3144_upgrade_to_bootstrap_5
branch
5 times, most recently
from
c8c06ca to
38fd2ca
Compare
This commit consists of the file changes required for the upgrade from Bootstrap 3 to 5. A more detailed version is in CHANGELOG.md (and in wiki: https://github.com/DMPRoadmap/roadmap/wiki/Release-notes-for-Bootstrap-5-upgrade)
gjacob24
force-pushed
the
issue_3144_upgrade_to_bootstrap_5
branch
from
611d64c to
932e31e
Compare
|
Closing this PR to create another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains the joint work of @johnpinto1 and @gjacob24 for the upgrade to Bootstrap 5 (#3144)
Version of code: v4.1.1
The
CHANGELOG.mdcontains a record of all the major changes.