Fix Template.latest_version Ambiguity Error
#3474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prior to this commit, the following error was encountered when applying the search filter within `/org_admin/templates`:
```
ActiveRecord::StatementInvalid - PG::AmbiguousColumn: ERROR: column reference "id" is ambiguous
LINE 1: SELECT COUNT(DISTINCT id) FROM (SELECT MAX(version) AS versi...
^:
app/views/layouts/_paginable.html.erb:5
app/controllers/concerns/paginable.rb:82:in `paginable_renderise'
app/controllers/paginable/templates_controller.rb:25:in `index'
```
- Tracing the code reveals that the query encountering this error is `Template.includes(:org).latest_version.where(customization_of: nil).distinct.total_count`.
- Although `SELECT "templates.*"` is the default behaviour of the `.latest_version` scope, the ambiguity error is raised unless `.select('templates.*')` is added explicitly.
|
Rather than updating the scope itself, I also could've addressed the ambiguity error via the following changes within
However, 3.1.4 :001 > Template.latest_version.to_sql
Creating scope :publicly_visible. Overwriting existing method Template.publicly_visible.
Creating scope :organisationally_visible. Overwriting existing method Template.organisationally_visible.
=> "SELECT \"templates\".* FROM (SELECT MAX(version) AS version, \"templates\".\"family_id\" FROM \"templates\" WHERE \"templates\".\"archived\" = FALSE GROUP BY \"templates\".\"family_id\") current INNER JOIN templates ON current.version = templates.version\n AND current.family_id = templates.family_id\nINNER JOIN orgs ON orgs.id = templates.org_id WHERE \"templates\".\"archived\" = FALSE" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes portagenetwork#941 (the same issue exists within DMP Roadmap)
Changes proposed in this PR:
/org_admin/templates:Tracing the code reveals that the query encountering this error is
Template.includes(:org).latest_version.where(customization_of: nil).distinct.total_count.Although
SELECT "templates.*"is the default behaviour of the.latest_versionscope, the ambiguity error is raised unless.select('templates.*')is added explicitly.