Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated border and background color for dnn-dropzone for compatibility with DNN 10 #1247

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

david-poindexter
Copy link
Contributor

@david-poindexter david-poindexter commented Jan 12, 2025

Updated border and background color for dnn-dropzone for compatibility with DNN 10. The screenshots below are based on the DNN CSS variables hard-coded in index.html so there may be a slight variation between them and what is actually in DNN 10. We may want to consider updating these in DNN elements to match DNN 10 now that it has been implemented in DNN 10.

image

image

Resolves #1246

@david-poindexter david-poindexter added the enhancement New feature or request label Jan 12, 2025
@david-poindexter david-poindexter added this to the 0.25.1 milestone Jan 12, 2025
@david-poindexter david-poindexter self-assigned this Jan 12, 2025
Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@valadas valadas merged commit e1057e1 into DNNCommunity:develop Jan 12, 2025
2 checks passed
@david-poindexter david-poindexter deleted the dropzone-border branch January 12, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use --dnn-color-foreground-light for border in dnn-dropzone component
2 participants