Fixed some issues with css-variables of inputs #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We created a way for people to be able to customize styles of input elements with some css-variables, however some of the variables defined were not being passed down to the wrapping fieldset causing confusion. Also the namin of those variables was a bit different from component to component, this PR also harmonizes that naming for avoiding further confusion. This rename is a slight breaking change, so I'll call attention to it in the release notes.
david-poindexter
requested changes
Jan 14, 2025
packages/stencil-library/src/components/dnn-select/dnn-select.scss
Outdated
Show resolved
Hide resolved
…scss Good catch Co-authored-by: David Poindexter <[email protected]>
david-poindexter
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We created a way for people to be able to customize styles of input elements with some css-variables, however some of the variables defined were not being passed down to the wrapping fieldset causing confusion.
Also the namin of those variables was a bit different from component to component, this PR also harmonizes that naming for avoiding further confusion. This rename is a slight breaking change, so I'll call attention to it in the release notes.
Example of some custom usage on a dark theme:
Closes #1251