-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added backup selection by resource #13
base: master
Are you sure you want to change the base?
Conversation
main.tf
Outdated
|
||
# AWS Backup selection - selection resources | ||
resource "aws_backup_selection" "backup_selection_resources" { | ||
count = var.account_type == local.account_type.workload ? 1 : 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the resource selection by ARN to the same backup selection block that already works with tags? https://github.com/DNXLabs/terraform-aws-backup/blob/master/main.tf#L62
main.tf
Outdated
plan_id = aws_backup_plan.backup_plan[0].id | ||
|
||
resources = [var.resources] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An input variable with the name "resources" has not been declared
shall we close it PR? still necessary changes? |
Added backup selection by resource
Types of changes
What types of changes does your code introduce to <repo_name>?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...