Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding allow_cidrs for replica instance #33

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

alandavid
Copy link
Contributor

Description:
This PR introduces the allow_cidrs variable to the Terraform module, enabling the configuration of CIDR blocks specifically for the replica instance. Previously, the module allowed setting CIDRs for the primary instance, but this enhancement extends that capability to the replica as well.

Changes:
Added allow_cidrs variable for the replica instance configuration.
Updated relevant Terraform files to include and manage the new variable.
Why:
Allowing CIDR blocks for the replica instance improves network security and flexibility, ensuring that both primary and replica instances can be securely accessed according to specified CIDR blocks.

Copy link

@tatamarques tatamarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alandavid alandavid merged commit e79bf12 into master Aug 12, 2024
@alandavid alandavid deleted the feature/read_replica_sg branch August 12, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants