Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DOMserver IPs #167

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Set DOMserver IPs #167

merged 7 commits into from
Sep 12, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Sep 10, 2024

See Pat's list, I'm not sure about the analyst instance if that is the host green or the host analyst-green, went with the analyst-green.

Onsite we should discuss which machine will be dualhomed or which firewall can be changed so we can manage the analyst instance.

This also requires a split in grouping to make sure that the analyst instance doesn't get a replication setup. It wouldn't hurt but its better to not install extras which are not needed as it opens up the sql server there in green.

See Pat's list, I'm not sure about the analyst instance if that is the
host `green` or the host `analyst-green`, went with the `analyst-green`.

Onsite we should discuss which machine will be dualhomed or which
firewall can be changed so we can manage the analyst instance.
This is needed because of the replication password, alternative would be
to do the same split as for online and not have so many groups in groups
but that also makes that we duplicate a lot of settings.
We now share all variables between both domservers so they share all
facts. Only the passwords are changed to make sure no data can leak if
we misconfigure the domserver URL in the analyst instance.
Copy link

gitguardian bot commented Sep 10, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
6152503 Triggered Generic Password 7730200 provision-contest/ansible/group_vars/onprem/secret.yml.example View secret
9997180 Triggered Username Password 7730200 provision-contest/ansible/group_vars/onprem/secret.yml.example View secret
9997181 Triggered Generic Password 7730200 provision-contest/ansible/group_vars/onprem/secret.yml.example View secret
6152502 Triggered Generic Password 7730200 provision-contest/ansible/group_vars/onprem/secret.yml.example View secret
6152499 Triggered Generic Password 7730200 provision-contest/ansible/group_vars/onprem/secret.yml.example View secret
6152500 Triggered Generic Password 7730200 provision-contest/ansible/group_vars/onprem/secret.yml.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@vmcj vmcj requested a review from nickygerritsen September 10, 2024 11:38

PHPSTORM_VERSION: 2022.2
PHPSTORM_FULL_VERSION: 222.4345.15

GRAFANA_MONITORING: false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping all this means we have no example of it anymore on main. Does that make sense?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, forgot to change the base to wfastana.

@vmcj vmcj changed the base branch from main to wfastana September 10, 2024 12:02
@vmcj vmcj merged commit 7e5202f into DOMjudge:wfastana Sep 12, 2024
2 of 3 checks passed
@vmcj vmcj deleted the ip_plan_astana branch September 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants