Skip to content

Commit

Permalink
Ignore 14 year old FIXME
Browse files Browse the repository at this point in the history
This assumes that in 14 year this has been fixed, according to https://www.php.net/manual/en/function.getopt.php
it does return the `false` but there is not easy way to verify this.
  • Loading branch information
Michael Vasseur committed Oct 20, 2024
1 parent 0b2d981 commit 43a0454
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion judge/judgedaemon.main.php
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,6 @@ function fetch_executable_internal(
}

$options = getopt("dv:n:hVe:j:t:", ["diskspace-error"]);
// FIXME: getopt doesn't return FALSE on parse failure as documented!
if ($options===false) {
echo "Error: parsing options failed.\n";
usage();
Expand Down

0 comments on commit 43a0454

Please sign in to comment.