Expose when externalContestSource (URI) returns non200 #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we are adding fields to the contest source anyway, we could also add the actual error there and display it on that page? |
We do show the HTTP error on the page, not on the internal error (yet) as I was not sure if we want the internal error. |
vmcj
force-pushed
the
event-feed-non200
branch
from
564d092 to
d876911
Compare
vmcj
force-pushed
the
event-feed-non200
branch
from
14bd399 to
88ddbf4
Compare
Exposes when externalContestSource (URI) returns a non HTTP 200. To trigger this: create a contest with http://URL// (the double // is important)
vmcj
force-pushed
the
event-feed-non200
branch
from
88ddbf4 to
711479c
Compare
nickygerritsen
approved these changes
Oct 7, 2023
meisterT
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To trigger this: create a contest with http://URL// (the double // is important)
Currently this does create the internal error but I'm not sure if we should do this, this is not really an internal error as its an external error. The InternalError class doesn't have support for this yet and we have nothing to disable.Currently ignoring the error works, resolving keeps on hanging.Opening the PR mostly for the discussion. Personally I think having an item under internalError view is nice as it alerts but its also a bit misusing the concept.This will add 1 extra alert in the shadow tab of the menu and mention that we're down.For the issue see: #2117