Fixes to executable table layout #2145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want this we should still remove the type from the table itself.
This needs to be further extended as debug and default compare scripts are now shown as unused.
meisterT
reviewed
Sep 17, 2023
meisterT
reviewed
Sep 17, 2023
meisterT
reviewed
Sep 17, 2023
|
I would try to have two tables, one with used and one unused executables and separating them by icon (and sorting) instead and see what looks better. |
|
I've now also labeled executables as disabled when the language they belong to are not allowed to be submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP but some questions on layout
Do we think the different tables are improvement or cluther?
Should I re-sort the tables on enabled/disabled. I think given that we have the
searchoption there it might make it cleaner.The code tag looks like an improvement:
