Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ScoreboardMergeCommand #2154

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

RagnarGrootKoerkamp
Copy link
Contributor

@RagnarGrootKoerkamp RagnarGrootKoerkamp commented Sep 23, 2023

Some changes I made:

  1. Allow reading from local files directly. It turns out to be more reliable to first download scoreboards from the API and then merge them when servers go down after the contest. (This needs e.g. - /path/to/scoreboards:/scoreboards in the docker-compose.yml which needs to be added manually.)
  2. Do not check that group IDs look like integers -- they can be strings.
  3. Match problems by display name instead of ID, since sites differ in whether they use A or problemshortname as ID.

I also had to disable showing the banner image, but I changed that by commenting it out in the twig. This needs some better fix.

(More comments in the script in BAPCtools that uses this.)

@RagnarGrootKoerkamp RagnarGrootKoerkamp force-pushed the scoreboardmerge_new branch 2 times, most recently from c8c414e to dec7b74 Compare September 24, 2023 14:59
@nickygerritsen
Copy link
Member

Can you look into the annotations reported by phpstan and the codestyle? Afterwards we can merge I tihnk.

@RagnarGrootKoerkamp
Copy link
Contributor Author

All should be/become green now

@nickygerritsen
Copy link
Member

Thanks!

@nickygerritsen nickygerritsen merged commit 081fc92 into DOMjudge:main Oct 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants