Allow reimport of contest & contest problems #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
commented
Sep 29, 2023
vmcj
changed the title
vmcj
force-pushed
the
reimport_contestproblem
branch
from
ba15c59 to
7f51165
Compare
|
I'll add a check for this case and add an optional confirmation that it should be overwritten. |
|
We explicit check for this to recreate those with a new name, so the intent of the earlier code was to create new ones instead of overwrite. |
This assume a default behaviour to always overwrite existing resources. It would be better if we have an option argument which states if we only want to create new, create new/update, append or recreate (so what to do with unset keys). Properly implementing that requires some discussion though.
Full reimport of example problems works both in datasource={0,1}
vmcj
force-pushed
the
reimport_contestproblem
branch
from
7f51165 to
f6b4990
Compare
nickygerritsen
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow having 2 contests with the same problems which is useful for the BAPC prelims where one DOMjudge instance hosts multiple contests for different locations (not to be confused with ICPC sites).
In the past the import-contest script would receive an 500 as we don't properly check if a problem with that name already exists.
This should make the import-contest idempotent.