Handle kotlinc symbolic link for determining KOTLIN_DIR #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Oct 7, 2023
|
I'd like input from others as well here. |
|
LGTM, but please squash the commits into a single one before merging. |
|
@agcom can you squash the commits? Afterwards we'll merge it. |
Find the real path of `kotlinc` in case it is a symbolic link, ensuring that the correct compiler directory containing `kotlinc` is determined. Previously, it directly used `dirname` on the result of `command -v kotlinc`, which could have led to incorrect directory when `kotlinc` was a symbolic link, and as a result, not finding the `kotlin-stdlib.jar` latter in the script.
|
@vmcj There you go. I thought there is an auto squash and merge option. |
There is, but some people like to have control on how the resulting message looks like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KOTLIN_DIRvariable needs to point to the compiler binary directory containing thekotlincbinary; because, latter in the script,KOTLIN_DIRis used to point to thekotlin-stdlib.jar; sometimeskotlincwould be just a symbolic link residing in a directory included in thePATHenvironment variable.It is possible to manually set the
KOTLIN_DIRvariable; but, with this change, unzipping the Kotlin installation and creating a symbolic link would suffice; see DOMjudge/domjudge-packaging#156.