Testcase judgehost naming #2211
Conversation
| if ($testcaseFromRequest) { | ||
| $tc = $this->em->getRepository(Testcase::class)->find($testcaseFromRequest); | ||
| if ($tc) { | ||
| return $this->redirectToRoute('jury_problem_testcases', ['probId' => $tc->getProblem()->getProbId()]); |
There was a problem hiding this comment.
I have the impression that this behavior can be very confusing. You are requesting one problem with a testcase from a different problem and are redirected?
Perhaps it becomes less confusing if we just add a separate route for it (in case it is useful)?
There was a problem hiding this comment.
So currently it is undocumented behaviour, and I think there are moments where you might want to know what testcase belongs with which problem (there is on the judgehost a system problem and you want to findout what kind of behaviour that problem has (loads of IO, loads of memory etc.)
I'm fine with just removing the commit, or just making a new route.
|
A screenshot would help for the second commit. |
vmcj
force-pushed
the
testcase_judgehost_naming
branch
from
0c3dde0 to
ec52400
Compare
| @@ -62,6 +63,7 @@ | |||
| title="Move testcase down"><i class="fas fa-arrow-down"></i></a> | |||
| {% endif %} | |||
| </td> | |||
| <td rowspan="2">{{ "%05d"|format(testcase.testcaseid) }}</td> | |||
There was a problem hiding this comment.
It would be nice to add a more complete path if it fits in the UI.
Needed for DOMjudge#2059, this now shows besides the rank (order of execution) also the ID in the database as these can be in different order. On the filesystem we have a form of `/2/2/testcase001` where this can now be checked against the UI.
With this we can now use: http://localhost/jury/problems/2/testcases?testcase=1 with the example problems and get redirected to problem 1 (hello world) as that has the first testcase. With this we have a shortcut to get from the judgehost directory to something in the UI.
This reverts commit 337bb6e. After discussion we didn't have a concrete usecase for this (yet).
And when you hover you get an educated guess for the absolute path. Educated as you can configure something else on the judgehost versus what you did on the domserver. |
vmcj
force-pushed
the
testcase_judgehost_naming
branch
from
ec52400 to
1adf8e5
Compare
When someone hovers over the relateive path they get an educated guess for the full path. If someone would use a different configure script (or other options) we can't guess the path on the domserver as the judgehost can work with different paths (prefix=$HOME versus prefix=/opt). For those users who did this they will be able to work this out from the absolute path.
vmcj
force-pushed
the
testcase_judgehost_naming
branch
from
1adf8e5 to
be3b7cf
Compare
|
I think #2324 is a better solution: both in the place/way the information is displayed and also by taking the actual directory from the judgehost instead of depending on configure/build time variables. |
fix #2059
@eldering is this what you wanted in the issue? I'm not sure how/where to document the 2nd commit and if we want it.