Fix order of judgings on submission page. #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found while looking at DOMjudge#2191, see this comment: DOMjudge#2191 (comment) Previously, we treated the start time as higher priority indicator than the judgingId for sorting the rows. For submissions that are queued we don't have a starttime yet, so they show up first. Now, the order is purely by judgingid. For one specific submission, the starttime of judgings should always be in order of their judgingid so this change should be a no-op otherwise.
nickygerritsen
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while looking at #2191, see this comment:
#2191 (comment)
Previously, we treated the start time as higher priority indicator than the judgingId for sorting the rows. For submissions that are queued we don't have a starttime yet, so they show up first.
Now, the order is purely by judgingid. For one specific submission, the starttime of judgings should always be in order of their judgingid so this change should be a no-op otherwise.