Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team clarification form updates. #2337

Merged
merged 6 commits into from
Feb 18, 2024

Conversation

nickygerritsen
Copy link
Member

Screenshot for the last commit:
image
@meisterT is this what you wanted?

@meisterT
Copy link
Member

Nice! I guess it's too hard to move the 'message preview' inside of the preview box (top right, perhaps italic?

Consider renaming 'message preview' to 'rendered preview'?

@nickygerritsen
Copy link
Member Author

I think both are possible. Let me try

@nickygerritsen
Copy link
Member Author

New screenshot:
image

I also applied this to the jury btw.

@meisterT
Copy link
Member

That looks good, I am considering doing a follow-up change similar to this:
image

@nickygerritsen
Copy link
Member Author

That looks good, I am considering doing a follow-up change similar to this: image

Feel free to push to my branch

@meisterT
Copy link
Member

pushed

@nickygerritsen
Copy link
Member Author

LGTM, when CI passes I will merge.

@nickygerritsen nickygerritsen added this pull request to the merge queue Feb 18, 2024
Merged via the queue into DOMjudge:main with commit 759f9e2 Feb 18, 2024
21 checks passed
@nickygerritsen nickygerritsen deleted the team-clarification-fixes branch February 18, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants