Replace data sources with shadow mode #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
reviewed
Jun 3, 2024
nickygerritsen
force-pushed
the
always-use-externalid
branch
3 times, most recently
from
080932d to
f0b4771
Compare
vmcj
reviewed
Jun 4, 2024
vmcj
reviewed
Jun 5, 2024
|
Overall I think this is good and we just need a contest to prove that it works but it would be good if someone else also takes a good look. |
|
It seems to be possible to modify the external IDs in the UI (might have been the case before). That seems asking for trouble. |
This was always possible yes. Are you proposing we disallow this after creation? I.e. only add it for new entities? |
|
That is my proposal indeed, but since you didn't introduce it in this PR, let's do in a separate one if you agree |
meisterT
approved these changes
Jun 6, 2024
vmcj
reviewed
Jun 6, 2024
vmcj
approved these changes
Jun 10, 2024
nickygerritsen
force-pushed
the
always-use-externalid
branch
from
fbc5c5a to
1c0d1e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2087
This makes the API always use external ID's and use sane defaults for the field if not provided.