Also test with the strict SQL version #2818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
integration_mymariasql
branch
6 times, most recently
from
6b11200 to
27a271f
Compare
vmcj
force-pushed
the
integration_mymariasql
branch
2 times, most recently
from
8f53f68 to
baa0a23
Compare
added 4 commits
November 24, 2024 15:28
To detect potential race conditions it's good to try to restructure the queries to fit in a higher level. Some companies/universities might run with this setting.
The original reason was after the `rank` becoming a protected keyword. As we depend on doctrine as abrstraction a lot it is good to verify that the translation is reasonable on backend SQL servers of whatever dialect.
vmcj
force-pushed
the
integration_mymariasql
branch
from
af658f8 to
2899dcb
Compare
Kevinjil
approved these changes
Nov 24, 2024
.github/workflows/integration.yml
Outdated
| - sql: mariadb | ||
| sql_options: --health-cmd="healthcheck.sh --connect --innodb_initialized" --health-interval=10s --health-timeout=5s --health-retries=3 | ||
| - sql: mysql | ||
| sql_options: --health-cmd="mysqladmin ping" --health-interval=5s --health-timeout=2s --health-retries=3 |
There was a problem hiding this comment.
Any reason why the health intervals differ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.