Fix fallthrough logic for cgroup version detection #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one of cgroup V1 or V2 can be enabled at a time, so it doesn't make sense to have fallthrough behaviour from V2 to V1. Instead of adding an `exit 0` at the end of the V2 case, add an `else` so that it is clearer that these are two mutually exclusive cases. Fixes a0728be
meisterT
approved these changes
Nov 24, 2024
nickygerritsen
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one of cgroup V1 or V2 can be enabled at a time, so it doesn't make sense to have fallthrough behaviour from V2 to V1. Instead of adding an
exit 0at the end of the V2 case, add anelseso that it is clearer that these are two mutually exclusive cases.Fixes a0728be