Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training test migration #1002

Merged
merged 33 commits into from
Oct 14, 2023
Merged

Training test migration #1002

merged 33 commits into from
Oct 14, 2023

Conversation

prishavall
Copy link
Contributor

What user problem are we solving?
Migrating unit tests from backend to the training module.

What solution does this PR provide?
Fixes the pathway errors and import changes with the transfer from backend to training.
Testing Methodology
How did you test your changes and verify that existing
functionality is not broken
Ran tests individually
Any other considerations
One test model_py is still not working need to look into django implementation for that.

@prishavall prishavall requested a review from a team as a code owner October 1, 2023 16:44
training/tests/test_loss_function.py Show resolved Hide resolved
training/tests/test_loss_function.py Show resolved Hide resolved
training/tests/test_loss_function.py Show resolved Hide resolved
training/tests/test_model.py Show resolved Hide resolved
training/tests/test_model.py Show resolved Hide resolved
training/tests/test_model.py Show resolved Hide resolved
@prishavall prishavall force-pushed the training-test-migration branch from 8c4976f to 9910b26 Compare October 1, 2023 16:50
@prishavall prishavall force-pushed the training-test-migration branch from cfbc400 to aad5576 Compare October 1, 2023 16:57
@karkir0003
Copy link
Member

@prishavall I got the build check to work for this action. Had to do some fixing with the micromamba action

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove debug prints (nits)

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added another quick comment

@prishavall prishavall added this pull request to the merge queue Oct 14, 2023
Merged via the queue into nextjs with commit 6caa54b Oct 14, 2023
7 checks passed
@prishavall prishavall deleted the training-test-migration branch October 14, 2023 02:25
@karkir0003 karkir0003 linked an issue Oct 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Migrate Pytests from /backend to /training
2 participants