Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux script updated to use dlp-cli #1088

Merged
merged 4 commits into from
Feb 21, 2024
Merged

tmux script updated to use dlp-cli #1088

merged 4 commits into from
Feb 21, 2024

Conversation

yebyyy
Copy link
Collaborator

@yebyyy yebyyy commented Jan 7, 2024

Feature 1081

Github Issue Number Here: #1081
tmux updated to use dlp-cli

modifying backend and frontend start code

runnning brew tmux install and ./tmux-script.sh

How did you test your changes and verify that existing functionality is not broken

Any other considerations

@yebyyy yebyyy requested a review from a team as a code owner January 7, 2024 00:04
Copy link
Contributor

sweep-ai bot commented Jan 7, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@karkir0003 karkir0003 linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@farisdurrani
Copy link
Member

Lgtm

@noah-iversen
Copy link
Contributor

noah-iversen commented Jan 13, 2024

Looks good, we still have to keep in mind this tmux script does not work in WSL currently. Still on our TODOs to iron out that issue.

@karkir0003
Copy link
Member

Looks good, we still have to keep in mind this tmux script does not work in WSL currently. Still on our TODOs to iron out that issue.

Got it @noah-iversen. I was able to run tmux-script.sh on windows, but through using Ubuntu terminal on windows

@karkir0003
Copy link
Member

Looks good, we still have to keep in mind this tmux script does not work in WSL currently. Still on our TODOs to iron out that issue.

@Keon-San have u tried running tmux -script.sh in wsl?

@karkir0003
Copy link
Member

@farisdurrani @yebyyy, @Keon-San tested this PR out and it works on WSL from my understanding.

@Keon-San can you confirm?

@farisdurrani
Copy link
Member

@Keon-San can you please fix the conflicts so we can proceed to merging?

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@farisdurrani
Copy link
Member

Works on Mac, feel free to merge

@Keon-San Keon-San added this pull request to the merge queue Feb 21, 2024
Merged via the queue into nextjs with commit 05f6406 Feb 21, 2024
4 checks passed
@Keon-San Keon-San deleted the feature-1081 branch February 21, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Tmux Script Update
5 participants