Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1123 ddb update #1125

Closed
wants to merge 10 commits into from
Closed

Feature 1123 ddb update #1125

wants to merge 10 commits into from

Conversation

MugPand
Copy link
Contributor

@MugPand MugPand commented Feb 5, 2024

DynamoDB & Terraform Update

Github Issue Number Here: GitHub #1123
What user problem are we solving?
The current DynamoDB tables and Terraform script reflect an older version of infra-configurations.

What solution does this PR provide?
Updated DynamoDB tables and Terraform script to reflect new changes proposed by the following diagram: Also added user_id as GSI to ModelTable.
image

Testing Methodology

How did you test your changes and verify that existing functionality is not broken
Ran terraform file configurations and validated created DynamoDB Tables on AWS.

Any other considerations

@MugPand MugPand requested a review from a team as a code owner February 5, 2024 01:45
@farisdurrani
Copy link
Member

farisdurrani commented Feb 5, 2024

Delete the *.tfstate* files. Ignore the Sonarcloud warning

@karkir0003
Copy link
Member

karkir0003 commented Feb 5, 2024

Delete the *.tfstate* files. Ignore the Sonarcloud warning

@farisdurrani should this be gitignored?

@karkir0003 karkir0003 closed this Feb 5, 2024
@karkir0003 karkir0003 reopened this Feb 5, 2024
@farisdurrani
Copy link
Member

Yes. Deleted and gitignored

@@ -0,0 +1,102 @@
import { APIGatewayProxyHandlerV2 } from "aws-lambda";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MugPand i think the api logic and terraform stuff is mixed int the same PR

Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

13.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@karkir0003 karkir0003 closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants