Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1123 Added Trainspace, Model, User Tables to Terraform Infra #1126

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

MugPand
Copy link
Contributor

@MugPand MugPand commented Feb 5, 2024

DynamoDB & Terraform Update

Github Issue Number Here: GitHub #1123
What user problem are we solving?
The current DynamoDB tables and Terraform script reflect an older version of infra-configurations.

What solution does this PR provide?
Updated DynamoDB tables and Terraform script to reflect new changes proposed by the following diagram: Also added user_id as GSI to ModelTable.
image

Testing Methodology

How did you test your changes and verify that existing functionality is not broken
Ran terraform file configurations and validated created DynamoDB Tables on AWS.

Any other considerations

@MugPand MugPand requested a review from a team as a code owner February 5, 2024 02:44
@MugPand MugPand changed the title Feature 1123 Feature 1123 Added Trainspace, Model, User Tables to Terraform Infra Feb 5, 2024
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@farisdurrani
Copy link
Member

This isn't mandatory but do try applying the tf plan and then destroy the built resources to make sure the .tf file works.

terraform init
terraform fmt
terraform plan
terraform apply
terraform destroy

It may not work if you don't have the proper access. I'll approve this after 24 hours to see if anyone else has any comments

@MugPand
Copy link
Contributor Author

MugPand commented Feb 5, 2024

This isn't mandatory but do try applying the tf plan and then destroy the built resources to make sure the .tf file works.

terraform init
terraform fmt
terraform plan
terraform apply
terraform destroy

It may not work if you don't have the proper access. I'll approve this after 24 hours to see if anyone else has any comments

@karkir0003 and I just tested that successfully.

@karkir0003
Copy link
Member

This isn't mandatory but do try applying the tf plan and then destroy the built resources to make sure the .tf file works.

terraform init
terraform fmt
terraform plan
terraform apply
terraform destroy

It may not work if you don't have the proper access. I'll approve this after 24 hours to see if anyone else has any comments

can we make this a best practice for tf related stuff?? can it be automated

@farisdurrani
Copy link
Member

Yes, this should be best practice. Can it be automated? Yes, but I won't recommend it. If it fails, there may be AWS resources that will never get destroyed (more cost)

@farisdurrani
Copy link
Member

Feel free to merge @MugPand

@MugPand MugPand added this pull request to the merge queue Feb 6, 2024
Merged via the queue into nextjs with commit 0151492 Feb 6, 2024
22 checks passed
@MugPand MugPand deleted the feature-1123 branch February 6, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants