-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate build and run environments using dev
variant
#294
Conversation
Thanks for this. I've checked that it works as advertised with
...which means daq-buildtools will need to account for cases where |
…into amogan/daq_release_issue134
Use coredaq instead of $spack_pkgname to check for the existence of the dev variant because $spack_pkgname might be "systems", which will never have that variant.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a regression test checking that using this feature branch of daq-buildtools, it still works fine with a "traditional" work area, i.e., one where fddaq
doesn't have a dev
variant. It did: https://github.com/DUNE-DAQ/daq-release/actions/runs/13141994553/workflow
Then yesterday I built a test nightly which used Andrew's feature branch in daq-release
and which installs fddaq+dev
and fddaq~dev
. I ran the suite of daq-buildtools tests on that test nightly, and again things looked fine: https://github.com/DUNE-DAQ/daq-release/actions/runs/13160749541
daq-buildtools can handle the dev
variants of fddaq
, and is also backwards compatible. Approved.
This PR depends on daq-release PR #119 which introduces the
dev
variant of theexternals
,coredaq
, andfddaq
umbrella packages. With these changes,dbt-create
will create a build environment which includescmake
,gdb
, andninja
, whiledbt-setup-release
will excludes those spack packages. This can be tested using the nightlyNFDU_DEV_241218_A9
, which was built using thedaq-release
branchamogan/issue134_build_vs_run_environments
which installs both the+dev
and~dev
variants. I've confirmed locally thatwhich cmake
returns the system-levelcmake
when using this version ofdbt-setup-release
, while creating a local area withdbt-create
and sourcing the localenv.sh
will pull in the spackcmake
used byexternals
.