"Daqify" cmake structure #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Append _test to unit test file names. This allows them to be found by the daq_add_unit_test() function - Remove the unittest directory's CMakeLists
- Add daq_setup_environment to ensure consistent build environment - Use daq_add_library to link dependencies - Add daq_add_python_bindings - Use daq_add_unit_test to handle unit tests (see previous commit) - Use daq_install() to install the project
|
Closing because Alex pointed out that this repo is intended to be used offline, more similar to |
|
After further discussion, Alessandro requested that the CMakeLists here use daq-cmake functions after all. |
…ogan/daqify_cmakelists
jcfreeman2
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After unsuccessfully trying to build
tpglibsin a local dunedaq area based on the latest nightly,NFD_DEV_240823_A9, I noticed the cmake structure wasn't very "dunedaq-y." This PR modifies theCMakeLists.txtand theunittestdirectory to be more conformant to the dunedaq structure:daq_setup_environment()for consistent build environmentdaq_add_library()to link dependenciesdaq_add_python_bindings()for python bindingsdaq_install()to install the projectdaq_add_unit_test()to find unit tests_testto unit test file names to that they can be found bydaq_add_unit_test()With these changes, I'm able to build
tpglibsin a local dunedaq area based onNFD_DEV_240823_A9.