Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D ROI #93

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

2D ROI #93

wants to merge 20 commits into from

Conversation

matthew-man-457
Copy link

2D Region of Interest filter for data reduction and low energy optimization, through zero-suppression of 'empty' channels.
Includes tools to run the ROI (as an Ana or Prod module) on Larsoft simulations and analyze its performance.

The workflow is as follows:
detsim_dune10kt_1x2x6_notpcsigproc.fcl
roiprod_job.fcl
solar_reco_dune10kt_1x2x6_tpcsigproc.fcl

@aolivier23 aolivier23 requested a review from mantheys January 31, 2025 16:04
@aolivier23
Copy link
Contributor

trigger build

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

@aolivier23
Copy link
Contributor

trigger build

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file necessary to running a module? If you can remove it without breaking your new feature, I can just approve this. We usually try to put .root and other binary files in StashCache so we don't use up our finite github space and don't cause git to slow down when it tries to compare binary files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be removed. I used it for generating a solar sample, but it's not necessary for running the ROI.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the file from my branch

Copy link
Contributor

@aolivier23 aolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment about binary file B8_spectrum.root. Can we just remove it? If not, it probably needs to go in StashCache.

delete binary file B8_spectrum.root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants