Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#153] PR 올릴 경우, 자동으로 build 실행 #154

Merged
merged 6 commits into from
Dec 18, 2023
Merged

[#153] PR 올릴 경우, 자동으로 build 실행 #154

merged 6 commits into from
Dec 18, 2023

Conversation

halfmoon-mind
Copy link
Member

Issue

Description

  • build 실행 시, 여러 에러를 발견하였습니다.
  • 관련된 에러 때문에 추후 진행될 배포 및 CICD에서도 많은 어려움이 있을 것으로 보여서 수정 PR을 올립니다.
  • 자동 리뷰어 등록
  • PR 생성시 Github Action으로 build 실행
  • CODEOWNER 추가해 자동 리뷰어 등록

Check List

  • PR 제목을 커밋 규칙에 맞게 작성
  • PR에 해당되는 Issue를 연결 완료
  • 적절한 라벨 설정
  • 작업한 사람 모두를 Assign
  • 작업한 팀에게 Code Review 요청 (Reviewer 등록)
  • main 브랜치의 최신 상태를 반영하고 있는지 확인

Screenshot

  • 세팅 관련 PR이라 관련된 스크린샷은 없습니다.

@halfmoon-mind halfmoon-mind added the fix 🧠 버그 수정하는 Issue label Dec 10, 2023
@halfmoon-mind halfmoon-mind self-assigned this Dec 10, 2023
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 10, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d97864
Status:🚫  Build failed.

View logs

@halfmoon-mind halfmoon-mind marked this pull request as draft December 11, 2023 00:14
@halfmoon-mind
Copy link
Member Author

계속 빌드가 안되서 해결하고 다시 PR 오픈하겠습니당

@halfmoon-mind halfmoon-mind marked this pull request as ready for review December 17, 2023 10:04
@halfmoon-mind
Copy link
Member Author

완료했습니다!

SujinKim1127
SujinKim1127 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@SujinKim1127 SujinKim1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업하시느라 고생하셨습니다!!!

@halfmoon-mind halfmoon-mind merged commit be7f8dd into main Dec 18, 2023
1 check passed
@halfmoon-mind halfmoon-mind deleted the fix/#153 branch December 18, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SujinKim1127 SujinKim1127 SujinKim1127 approved these changes

@ChoiSangwon ChoiSangwon Awaiting requested review from ChoiSangwon

@JooHui-void JooHui-void Awaiting requested review from JooHui-void

@jwo0o0 jwo0o0 Awaiting requested review from jwo0o0

Assignees

@halfmoon-mind halfmoon-mind

Labels
fix 🧠 버그 수정하는 Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halfmoon-mind @SujinKim1127