-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#129] 공지사항, 펀시스템 상세정보 및 댓글 API 연결 #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
제가 noticeAPIs.ts 에서 작업하고 주희님이 noticeAPIS.ts로 작업해서 뭔가 충돌이 난것 같습니다.. 파일이 이상하네요
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SujinKim1127
requested review from
JooHui-void,
chan0310,
jwo0o0 and
halfmoon-mind
December 20, 2023 03:54
빌드 안되는데 한번 확인해주세요 @SujinKim1127 |
SujinKim1127
changed the title
[#129] 공지사항, 펀시스템, 커뮤니티 상세정보 및 댓글 API 연결
[#129] 공지사항, 펀시스템 상세정보 및 댓글 API 연결
Dec 20, 2023
jwo0o0
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if문으로 나누는건.. switch case문도 있겠지만 찾아보니까 작은 범위 안에서는 if-else가 속도면에서 더 빠르다네요!
그리고 [id] 동적 페이지에서는const pathId = router.query.id
로도 가져올 수 있슴다
halfmoon-mind
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
(pr close 한 상태로 rebase를 하면 다시 오픈을 할 수가 없군요... 처음 알았슴당..)
pages/funsystem/[id].tsx
파일을 추가했습니다useEffect
안에서 if문을 설정해서 만들어뒀는데 이렇게 하는게 맞는지 잘 모르겠습니다 ㅠㅠ이렇게 하는 방법보다 더 좋은 방법이 있을까유...?
Check List
main
브랜치의 최신 상태를 반영하고 있는지 확인Screenshot