Vibration to the ship lever when holding it #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2duviz2
commented
Aug 30, 2024
DaXcess
reviewed
Aug 30, 2024
| @@ -98,15 +100,23 @@ private void Update() | |||
| shouldTrigger = eulerAngles.x > 290 ? TriggerDirection.DepartShip : TriggerDirection.None; | |||
| } | |||
|
|
|||
| if (CurrentInteractor != null && Mathf.Abs(LastRot - eulerAngles.y) >= 5) | |||
There was a problem hiding this comment.
This checks only the Y angle, which is hardcoded to be only either 90 degrees, or 270 degrees, making this code basically a no-op. The lever interaction requires a rework before such a feature can be added properly.
|
Lever interaction requires a rework before this feature can be added properly. |
|
Lever rework has been added to #259, but is not planned for next update |
…s an extra Changed the angle from y to x Added vibration the pulling the lever Clamped the levers rotation to avoid it from clipping
2duviz2
commented
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change, but makes it more inmersive