Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging to upstream #2

Closed
1 of 11 tasks
illwieckz opened this issue Feb 18, 2018 · 1 comment
Closed
1 of 11 tasks

merging to upstream #2

illwieckz opened this issue Feb 18, 2018 · 1 comment

Comments

@illwieckz
Copy link
Member

illwieckz commented Feb 18, 2018

I move the issue there so we can remove the old unvanquished fork.

There was some PR made on BinomialLLC's side but they were not merged:

Since they officially stated they don't support crunch any more, it's likely to never happens.

Then Unity people took the code and improved it a lot, so I replayed the commits on their tree with hope they will upstream them, I also added another commit to fix an issue they introduced:

Basically the commits fix compilation on 64 bit, fix compilation on Linux, fix build outside of Visual Studio, and add an improvement: to renormalize on the top of mip-level too using the -rtopmip option with the --renormalize one, allow user-defined CRND_ASSERT, fix malloc on macOS and FreeBSD.

@illwieckz
Copy link
Member Author

We stopped creating PR to upstream long time ago. None of ours were merged, and PR from others didn't get merged either.

Let's accept our fate, a merge to upsteam will never happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant